Skip to content

[CMAKE][CORE] Move CRCDiff tool to Core #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

[CMAKE][CORE] Move CRCDiff tool to Core #684

merged 1 commit into from
Apr 17, 2025

Conversation

feliwir
Copy link

@feliwir feliwir commented Apr 15, 2025 •
edited by xezon
Loading

This change moves the CRCDiff tool to Core. The files were an exact match between Generals and Zero Hour.

@feliwir feliwir added Unify Unifies code between Generals and Zero Hour Tools Affects Tools only Build Anything related to building, compiling labels Apr 15, 2025
xezon
xezon reviewed Apr 16, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change forgot to remove the CRCDiff from Generals.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Apr 16, 2025
@feliwir feliwir requested a review from xezon April 16, 2025 22:06
@feliwir feliwir merged commit 8210b76 into TheSuperHackers:main Apr 17, 2025
18 checks passed
@xezon xezon mentioned this pull request Apr 18, 2025
Open
41 tasks
@xezon xezon removed the Minor Severity: Minor < Major < Critical < Blocker label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsons26 tomsons26 tomsons26 approved these changes

@xezon xezon xezon approved these changes

@OmniBlade OmniBlade Awaiting requested review from OmniBlade

@Mauller Mauller Awaiting requested review from Mauller

Assignees
No one assigned
Labels
Build Anything related to building, compiling Tools Affects Tools only Unify Unifies code between Generals and Zero Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feliwir @tomsons26 @xezon