-
Notifications
You must be signed in to change notification settings - Fork 78
[CMAKE][CORE] Move WWLib and WWDebug to Core #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 302 out of 307 changed files in this pull request and generated no comments.
Files not reviewed (5)
- Core/CMakeLists.txt: Language not supported
- Core/Libraries/CMakeLists.txt: Language not supported
- Core/Libraries/Source/WWVegas/CMakeLists.txt: Language not supported
- Core/Libraries/Source/WWVegas/WWDebug/CMakeLists.txt: Language not supported
- Core/Libraries/Source/WWVegas/WWLib/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
Core/Libraries/Source/WWVegas/WWDebug/wwdebug.h:112
- [nitpick] Consider using a more formal comment style and removing developer-specific tags for clarity; a descriptive comment explaining the rationale for choosing the ZH path would be more suitable for production code.
// TheSuperHackers: @compile feliwir 12/04/2025: Both Debug headers are identical. Use ZH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this, we need to properly sync left over files in WWlib from Zero Hour to Generals:
mempool.h
trim.cpp
widestring.cpp
widestring.h
wwstring.cpp
wwstring.h
And the various files in WWDebug.
This change as is hides the differences between the games.
529bd0e
to
694c846
Compare
I cannot push to this branch.
|
2d5f58d
to
0f252f6
Compare
Why does this change suddenly show a diff on 383 files? |
How many files should it be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This change moves the wwlib and wwdebug libraries to Core. The source files were previously properly unified between Generals and Zero Hour.