perf(gui): Eliminate expensive and unnecessary processing when populating the replay and map lists after they are full #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
xezon
force-pushed
the
xezon/optimize-replay-list
branch
from
7dee951 to
d7957f8
Compare
Skyaero42
requested changes
Oct 28, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Show resolved
Hide resolved
xezon
force-pushed
the
xezon/optimize-replay-list
branch
from
d7957f8 to
bfc056e
Compare
Skyaero42
approved these changes
Oct 31, 2025
Author
|
Generals MapUtil file has some discrepancies. Waiting for merge #1771 before replicating this change to Generals. |
xezon
force-pushed
the
xezon/optimize-replay-list
branch
from
bfc056e to
6ec8f40
Compare
Author
|
Rebased on main with conflicts. Replicated to Generals without conflicts. Additionally I applied while loop to for loop refactors in MapUtil.h. |
…ting the replay and map lists after they are full (#1758)
xezon
force-pushed
the
xezon/optimize-replay-list
branch
from
6ec8f40 to
983017d
Compare
Author
|
Rebased again after #1767 was merged. |
xezon
added a commit
that referenced
this pull request
Nov 1, 2025
…ting the replay and map lists after they are full (#1758)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ting the replay and map lists after they are full (TheSuperHackers#1758)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change eliminates expensive and unnecessary processing when populating the replay and map lists after they are full.
This was mostly noticable with the Replay list when reading replays files after the list (100) was already fully populated.
The Custom Maps list (300) was also susceptible to extra cost, but not as much because it uses the map cache.
To improve Replay Menu performance further, we also need a Replay Cache.
TODO