feat(gui): Implement replay info tooltips in Replay Menu #1720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stubbjax
added
Enhancement
xezon
reviewed
Oct 22, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Outdated
Show resolved
Hide resolved
| AsciiString replayFileNameAscii; | ||
| replayFileNameAscii.translate(replayFileName); | ||
|
|
||
| std::map<AsciiString, ReplayInfoCacheEntry>::const_iterator it = replayInfoCache.find(replayFileNameAscii); |
There was a problem hiding this comment.
Can we use UnicodeString as map key here?
But it looks like the other function also uses AsciiString for Replay Names. It is strange that it does that and I wonder how this works with non ascii chars.
Author
There was a problem hiding this comment.
I did initially try this but it caused replayInfoCache[asciistr] = entry; to fail, so either way a conversion is required. I can replace it with an AsciiString → UnicodeString translation.
There was a problem hiding this comment.
What happens if we put Chinese Characters in Replay Name? Does it show and load?
Author
There was a problem hiding this comment.
Replays with Chinese characters in the name do not show in retail.
There was a problem hiding this comment.
Dang. Maybe we can fix that in another change.
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Show resolved
Hide resolved
xezon
reviewed
Oct 23, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Outdated
Show resolved
Hide resolved
Stubbjax
force-pushed
the
replay-info-tooltips
branch
from
ba6472e to
36bca60
Compare
xezon
reviewed
Oct 24, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Outdated
Show resolved
Hide resolved
| UnicodeString mapStr = createMapName(asciistr, info, mapData); | ||
|
|
||
| // extra | ||
| UnicodeString extraStr = buildReplayTooltip(header, info); |
Stubbjax
force-pushed
the
replay-info-tooltips
branch
from
36bca60 to
ec3e6c6
Compare
Stubbjax
force-pushed
the
replay-info-tooltips
branch
from
ec3e6c6 to
9445a43
Compare
xezon
approved these changes
Oct 27, 2025
xezon
changed the title
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…kers#1720) Hovering a replay in the list will now show a tooltip with match duration, fps and human player names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to hover replays in the replays menu to observe additional data in the tooltip, including the duration and the players involved. This mostly leverages existing (previously disabled) logic with a few minor tweaks to make it a bit more tooltip-friendly.
TOOLTIPS.mp4