bugfix(buildassistant): Fix Network game mismatch by using the correct player index to check shroud status when placing structures #1646
Conversation
Stubbjax
added
Blocker
|
This now fails the Replay Check, so is still not right. |
Ah, the player index might need to be the local player as it's from their perspective. |
Stubbjax
force-pushed
the
fix-shrouded-building-placement
branch
from
a34b0f2 to
9cf4866
Compare
Stubbjax
force-pushed
the
fix-shrouded-building-placement
branch
from
9cf4866 to
1ba188e
Compare
|
I've investigated / tested a bit more and believe I have a solution that resolves desync issues and stuck AI. |
Stubbjax
force-pushed
the
fix-shrouded-building-placement
branch
from
ed2c50a to
fa83ef7
Compare
…c issues and stuck AI
Generals/Code/GameEngine/Source/Common/System/BuildAssistant.cpp
Outdated
Show resolved
Hide resolved
| { | ||
| if (them->testStatus(OBJECT_STATUS_IS_USING_ABILITY) || them->getAI() && them->getAI()->isBusy()) | ||
| { | ||
| return LBC_OBJECTS_IN_THE_WAY; |
There was a problem hiding this comment.
Side note: I wonder if this code path is missing TheTerrainVisual->addFactionBib( them, TRUE );...
There was a problem hiding this comment.
Include that with this change?
There was a problem hiding this comment.
Separate. Was just wondering about it as I looked at this code here.
xezon
changed the title
…t player index to check shroud status when placing structures (TheSuperHackers#1646)
2 participants
Fixes #1644
This change fixes an issue introduced by #1543 which used local drawable state that was also used by game logic paths, leading to desynchronised behaviour.