[GEN][ZH] Prevent a custom Display Resolution from changing when making other changes in the Options Menu #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
changed the title
xezon
commented
Jun 8, 2025
Author
There was a problem hiding this comment.
This is an additional sneaky bug. It changes the resolution to what the combo box default is without confirming any resolution change. This causes a notable bug when declining a resolution change. Afterwards the GlobalData resolution is incorrectly set and causes misbehavior in the Options Menu resolution combo box.
xezon
commented
Jun 8, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
Mauller
approved these changes
Jun 9, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Works as intended when run in windowed mode, i have not tested in fullscreen yet since i have other things going on.
…hanges in the Options Menu
xezon
force-pushed
the
xezon/fix-optionsmenu-custom-resolution
branch
from
9032226 to
e70c10a
Compare
|
Copy across looks clean |
Author
|
Replicated in Generals. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ng other changes in the Options Menu (TheSuperHackers#1030)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents a custom display resolution from changing when making changes in the Options Menu.
Originally, the Display Resolution combo box in the Options Menu did not recognize custom resolutions that were set in the Options.ini. This would force the resolution to change when applying any changes in the Options Menu. When this happened in-game, then the game crashed.
A custom resolution now shows in the Combo Box
TODO