[GEN][ZH] Prevent crashing from evaluating and saving disabled options in the Options Menu #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
approved these changes
Jun 9, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks good and works as expected.
A really nice improvement when coupled with the scrolling fixes
xezon
force-pushed
the
xezon/fix-optionsmenu-disabled-options
branch
from
0b70511 to
2b6d5bd
Compare
xezon
changed the title
Author
|
Replicated in Generals without conflicts. |
|
Copy across looks clean. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…s in the Options Menu (TheSuperHackers#1028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents evaluating and saving disabled options in the Options Menu when in-game.
Originally, the game evaluated disabled options. This most notably happened with the disabled Display Resolution settings, when a custom resolution forced the game to default its resolution to 800x600 and then crash the game when pressing the ACCEPT button.
TODO