In-Game options change resets resolution to 800x600 and crashes the game

[L3-M]

Changing in-game options resets the resolution to 800x600 and crashes the game. GenTool fixes this with a hack.

Retail 1.04/vs6 build:

1.mp4

Retail 1.04 + GenTool:

2.mp4

[xezon]

GenTool avoids this problem by preventing the resolution change when the "resolution lock" option is enabled in the GenTool menu. That is not the proper fix.

The proper fix is to not arbitrarily change the resolution when it does not match a resolution entry from the combo box. To do that, we probably need to add the current custom resolution to the resolution combo box.

And on top of that need to fix the real crash on resolution change as well, whereever that shows to be.

[Sinio-Manoka]

GenTool avoids this problem by preventing the resolution change when the "resolution lock" option is enabled in the GenTool menu. That is not the proper fix.

The proper fix is to not arbitrarily change the resolution when it does not match a resolution entry from the combo box. To do that, we probably need to add the current custom resolution to the resolution combo box.

And on top of that need to fix the real crash on resolution change as well, whereever that shows to be.

This could be added in the OptionsMenu.cpp

[xezon]

Resolution change in Ingame Options Menu triggers

=================================================================
==22072==ERROR: AddressSanitizer: heap-use-after-free on address 0x229230f8 at pc 0x00b06895 bp 0x0155efd8 sp 0x0155efd8
READ of size 4 at 0x229230f8 thread T0
==22072==WARNING: Failed to use and restart external symbolizer!
    #0 0x00b06894 in W3DGadgetPushButtonImageDrawOne D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\GUI\Gadget\W3DPushButton.cpp:422
    #1 0x00b06455 in W3DGadgetPushButtonImageDraw D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\GUI\Gadget\W3DPushButton.cpp:316
    #2 0x004f5eb6 in GameWindowManager::drawWindow D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:1298
    #3 0x004f5fb7 in GameWindowManager::drawWindow D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:1313
    #4 0x004f5fb7 in GameWindowManager::drawWindow D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:1313
    #5 0x004f5fb7 in GameWindowManager::drawWindow D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:1313
    #6 0x004fd31d in GameWindowManager::winRepaint D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:1353
    #7 0x00ae6ea9 in W3DInGameUI::draw D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\W3DInGameUI.cpp:439
    #8 0x00adb5aa in W3DDisplay::draw D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\W3DDisplay.cpp:1902
    #9 0x004e11eb in GameClient::update D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GameClient.cpp:766
    #10 0x003897df in GameEngine::update D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp:746
    #11 0x009b24ad in Win32GameEngine::update D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\Win32Device\Common\Win32GameEngine.cpp:90
    #12 0x00386b5a in GameEngine::execute D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp:822
    #13 0x00376e55 in GameMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameMain.cpp:44
    #14 0x00373759 in WinMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\Main\WinMain.cpp:986
    #15 0x00d665c6 in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #16 0x7571fcc8 in BaseThreadInitThunk+0x18 (C:\WINDOWS\System32\KERNEL32.DLL+0x6b81fcc8)
    #17 0x773682ad in RtlGetAppContainerNamedObjectPath+0x11d (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e82ad)
    #18 0x7736827d in RtlGetAppContainerNamedObjectPath+0xed (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e827d)

0x229230f8 is located 24 bytes inside of 32-byte region [0x229230e0,0x22923100)
freed by thread T0 here:
    #0 0x5388e6ed in free D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_malloc_win.cpp:125
    #1 0x538a081c in __asan::__RuntimeFunctions<__asan::Ucrtbase>::Free D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_win_runtime_functions.cpp:273
    #2 0x00d65ca3 in operator delete D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_win_delete_scalar_size_thunk.cpp:44
    #3 0x0053104f in ControlBar::~ControlBar D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp:1042
    #4 0x0053156a in ControlBar::`scalar deleting destructor'+0xa (C:\Generals\English\Command & Conquer Generals Zero Hour\generalszh.exe+0x5e156a)
    #5 0x00568aa4 in InGameUI::recreateControlBar D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\InGameUI.cpp:5667
    #6 0x0052df22 in saveOptions D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GUICallbacks\Menus\OptionsMenu.cpp:1125
    #7 0x00527046 in OptionsMenuSystem D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GUICallbacks\Menus\OptionsMenu.cpp:2024
    #8 0x004fd50f in GameWindowManager::winSendSystemMsg D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:709
    #9 0x004f169b in PassMessagesToParentSystem D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:174
    #10 0x004fd50f in GameWindowManager::winSendSystemMsg D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:709
    #11 0x008cb5ad in GadgetPushButtonInput D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\Gadget\GadgetPushButton.cpp:223
    #12 0x004fd47f in GameWindowManager::winSendInputMsg D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:728
    #13 0x004fc497 in GameWindowManager::winProcessMouseEvent D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindowManager.cpp:930
    #14 0x008d6c53 in WindowTranslator::translateGameMessage D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\MessageStream\WindowXlat.cpp:247
    #15 0x0039a93c in MessageStream::propagateMessages D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\MessageStream.cpp:1096
    #16 0x003897ea in GameEngine::update D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp:747
    #17 0x009b24ad in Win32GameEngine::update D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\Win32Device\Common\Win32GameEngine.cpp:90
    #18 0x00386b5a in GameEngine::execute D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp:822
    #19 0x00376e55 in GameMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameMain.cpp:44
    #20 0x00373759 in WinMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\Main\WinMain.cpp:986
    #21 0x00d665c6 in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #22 0x7571fcc8 in BaseThreadInitThunk+0x18 (C:\WINDOWS\System32\KERNEL32.DLL+0x6b81fcc8)
    #23 0x773682ad in RtlGetAppContainerNamedObjectPath+0x11d (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e82ad)
    #24 0x7736827d in RtlGetAppContainerNamedObjectPath+0xed (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e827d)

previously allocated by thread T0 here:
    #0 0x5388e7ed in malloc D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_malloc_win.cpp:134
    #1 0x0037434a in operator new D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\System\GameMemoryNull.cpp:158
    #2 0x008cbd5c in getNewPushButtonData D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\Gadget\GadgetPushButton.cpp:603
    #3 0x008cad40 in GadgetButtonDrawOverlayImage D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\Gadget\GadgetPushButton.cpp:682
    #4 0x00539312 in ControlBar::setPortraitByObject D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp:2689
    #5 0x00539e33 in ControlBar::switchToContext D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp:2131
    #6 0x0053484d in ControlBar::init D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp:1286
    #7 0x0056433d in InGameUI::init D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\InGameUI.cpp:1185
    #8 0x004df1ac in GameClient::init D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GameClient.cpp:374
    #9 0x003a8f62 in SubsystemInterfaceList::initSubsystem D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\System\SubsystemInterface.cpp:162
    #10 0x0038849c in GameEngine::init D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp:503
    #11 0x00376e22 in GameMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameMain.cpp:41
    #12 0x00373759 in WinMain D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\Main\WinMain.cpp:986
    #13 0x00d665c6 in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #14 0x7571fcc8 in BaseThreadInitThunk+0x18 (C:\WINDOWS\System32\KERNEL32.DLL+0x6b81fcc8)
    #15 0x773682ad in RtlGetAppContainerNamedObjectPath+0x11d (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e82ad)
    #16 0x7736827d in RtlGetAppContainerNamedObjectPath+0xed (C:\WINDOWS\SYSTEM32\ntdll.dll+0x4b2e827d)

SUMMARY: AddressSanitizer: heap-use-after-free D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\W3DDevice\GameClient\GUI\Gadget\W3DPushButton.cpp:422 in W3DGadgetPushButtonImageDrawOne
Shadow bytes around the buggy address:
  0x22922e00: fa fa 00 00 00 00 fa fa 00 00 00 01 fa fa 00 00
  0x22922e80: 00 02 fa fa fd fd fd fa fa fa fd fd fd fa fa fa
  0x22922f00: fd fd fd fa fa fa fd fd fd fd fa fa fd fd fd fd
  0x22922f80: fa fa fd fd fd fa fa fa 00 00 00 04 fa fa 00 00
  0x22923000: 00 04 fa fa 00 00 00 04 fa fa 00 00 00 04 fa fa
=>0x22923080: 00 00 00 04 fa fa fd fd fd fa fa fa fd fd fd[fd]
  0x22923100: fa fa 00 00 00 fa fa fa 00 00 00 04 fa fa 00 00
  0x22923180: 07 fa fa fa 00 00 00 fa fa fa 00 00 00 fa fa fa
  0x22923200: 00 00 00 fa fa fa 00 00 00 fa fa fa 00 00 00 fa
  0x22923280: fa fa fd fd fd fa fa fa fd fd fd fa fa fa fd fd
  0x22923300: fd fa fa fa fd fd fd fa fa fa 00 00 00 fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
Address Sanitizer Error: Use of deallocated memory