Fixes

Author: TheRandomLabs

config/spotbugs-exclude.xml

@@ -1,4 +1,12 @@
 <FindBugsFilter>
+	<Match>
+		<Bug pattern="EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS"/>
+	</Match>
+
+	<Match>
+		<Bug pattern="UWF_UNWRITTEN_FIELD"/>
+	</Match>
+
 	<Match>
 		<Class name="~.*Test"/>
 

src/main/java/com/therandomlabs/curseapi/minecraft/ForgeSVCMinecraftProvider.java

@@ -24,22 +24,7 @@ public final class ForgeSVCMinecraftProvider implements CurseAPIProvider {
 	static final ForgeSVCMinecraft FORGESVC_MINECRAFT =
 			RetrofitUtils.get("https://addons-ecs.forgesvc.net/").create(ForgeSVCMinecraft.class);
 
-	static final SortedSet<MCVersion> versions;
-
-	static {
-		try {
-			final List<MCVersion> versionList =
-					RetrofitUtils.execute(FORGESVC_MINECRAFT.getVersions());
-
-			for (int i = 0; i < versionList.size(); i++) {
-				versionList.get(i).setIndex(i);
-			}
-
-			versions = ImmutableSortedSet.copyOf(versionList);
-		} catch (CurseException ex) {
-			throw new IllegalStateException("Failed to retrieve Minecraft versions", ex);
-		}
-	}
+	static final SortedSet<MCVersion> versions = getVersions();
 
 	private ForgeSVCMinecraftProvider() {}
 
@@ -50,4 +35,20 @@ private ForgeSVCMinecraftProvider() {}
 	public SortedSet<? extends CurseGameVersion<?>> gameVersions(int id) {
 		return id == CurseAPIMinecraft.MINECRAFT_ID ? new TreeSet<>(versions) : null;
 	}
+
+	@SuppressWarnings("PMD.ForLoopCanBeForeach")
+	private static SortedSet<MCVersion> getVersions() {
+		try {
+			final List<MCVersion> versions =
+					RetrofitUtils.execute(FORGESVC_MINECRAFT.getVersions());
+
+			for (int i = 0; i < versions.size(); i++) {
+				versions.get(i).setIndex(i);
+			}
+
+			return ImmutableSortedSet.copyOf(versions);
+		} catch (CurseException ex) {
+			throw new IllegalStateException("Failed to retrieve Minecraft versions", ex);
+		}
+	}
 }

src/main/java/com/therandomlabs/curseapi/minecraft/MCVersion.java

@@ -1,20 +1,17 @@
 package com.therandomlabs.curseapi.minecraft;
 
-import java.util.SortedSet;
-
 import com.therandomlabs.curseapi.game.CurseGameVersion;
 
 /**
  * Represents a version of Minecraft supported by CurseForge.
  */
 public final class MCVersion extends CurseGameVersion<MCVersion> {
-	static SortedSet<MCVersion> versions;
-
 	private int index;
 	private String versionString;
 
 	/**
 	 * Returns the value returned by {@link #versionString()}.
+	 *
 	 * @return the value returned by {@link #versionString()}}.
 	 */
 	@Override
@@ -26,24 +23,24 @@ public String toString() {
 	 * {@inheritDoc}
 	 */
 	@Override
-	public int compareTo(MCVersion version) {
-		return Integer.compare(version.index, index);
+	public int gameID() {
+		return CurseAPIMinecraft.MINECRAFT_ID;
 	}
 
 	/**
 	 * {@inheritDoc}
 	 */
 	@Override
-	public int gameID() {
-		return CurseAPIMinecraft.MINECRAFT_ID;
+	public String versionString() {
+		return versionString;
 	}
 
 	/**
 	 * {@inheritDoc}
 	 */
 	@Override
-	public String versionString() {
-		return versionString;
+	public int compareTo(MCVersion version) {
+		return Integer.compare(version.index, index);
 	}
 
 	//This method is called by ForgeSVCMinecraftProvider.

src/main/java/com/therandomlabs/curseapi/minecraft/MCVersions.java

@@ -2,6 +2,7 @@
 
 import java.util.SortedSet;
 import java.util.TreeSet;
+import java.util.stream.Stream;
 
 /**
  * Contains {@link MCVersion} constants that represent all versions of Minecraft supported
@@ -308,7 +309,6 @@ public final class MCVersions {
 	 */
 	public static final MCVersion V1_14_4 = get("1.14.4");
 
-
 	private MCVersions() {}
 
 	/**
@@ -321,6 +321,15 @@ public static SortedSet<MCVersion> getAll() {
 		return new TreeSet<>(ForgeSVCMinecraftProvider.versions);
 	}
 
+	/**
+	 * Returns a {@link Stream} for all Minecraft versions supported by CurseForge.
+	 *
+	 * @return a {@link Stream} for all Minecraft versions supported by CurseForge.
+	 */
+	public static Stream<MCVersion> streamAll() {
+		return ForgeSVCMinecraftProvider.versions.stream();
+	}
+
 	private static MCVersion get(String versionString) {
 		for (MCVersion version : ForgeSVCMinecraftProvider.versions) {
 			if (versionString.equals(version.versionString())) {