Update README.md#4
Merged
Merged
Conversation
Having to change 'xit's in exercises like repeatString for testing exercise solutions was not immediately obvious. I felt it should be mentioned so newbies before me won't face confusing jasmine messages about xits when testing their code. I don't know how the wording of the readme is really intended, so I hope my change will address this properly.
Member
|
gah! Good catch! This is the change that i had made that we lost when I undid my stupid 'solutions' merge. Thanks for this PR 👍 |
willgodev
pushed a commit
to willgodev/javascript-exercises
that referenced
this pull request
Dec 21, 2020
Update README.md
milanmomcilovic96
added a commit
to milanmomcilovic96/javascript-exercises
that referenced
this pull request
Jan 28, 2022
RSBlackrose
added a commit
to RSBlackrose/javascript-exercises
that referenced
this pull request
Mar 12, 2022
risseado
pushed a commit
to risseado/javascript-exercises
that referenced
this pull request
Apr 9, 2022
Quick word change in comment
ronsamgeorge
added a commit
to ronsamgeorge/javascript-exercises
that referenced
this pull request
Apr 24, 2022
JFerrettUK
added a commit
to JFerrettUK/javascript-exercises
that referenced
this pull request
Jun 5, 2022
larantula
added a commit
to larantula/javascript-exercises
that referenced
this pull request
Jun 17, 2022
bmilcs
added a commit
to bmilcs/odin-javascript-exercises
that referenced
this pull request
Jul 25, 2022
bmilcs
added a commit
to bmilcs/odin-javascript-exercises
that referenced
this pull request
Jul 25, 2022
k-fields
pushed a commit
to k-fields/javascript-exercises
that referenced
this pull request
Aug 10, 2022
Namin404
added a commit
to Namin404/javascript-exercises
that referenced
this pull request
Aug 18, 2022
sinahuss
added a commit
to sinahuss/javascript-exercises
that referenced
this pull request
Aug 20, 2022
Supablu
added a commit
to Supablu/javascript-exercises
that referenced
this pull request
Sep 20, 2022
nathenialalleyne
added a commit
to nathenialalleyne/javascript-exercises
that referenced
this pull request
Sep 27, 2022
mikiyabu
added a commit
to mikiyabu/javascript-exercises
that referenced
this pull request
Oct 2, 2022
tilenmars
added a commit
to tilenmars/javascript-exercises
that referenced
this pull request
Oct 30, 2022
tilenmars
added a commit
to tilenmars/javascript-exercises
that referenced
this pull request
Oct 30, 2022
sunny852206
added a commit
to sunny852206/javascript-exercises
that referenced
this pull request
Nov 2, 2022
Endeared
added a commit
to Endeared/javascript-exercises
that referenced
this pull request
Dec 3, 2022
rdansie
added a commit
to rdansie/javascript-exercises
that referenced
this pull request
Dec 19, 2022
jpawz
added a commit
to jpawz/javascript-exercises
that referenced
this pull request
Jan 8, 2023
Kenfresno
added a commit
to Kenfresno/odin-javascript-exercises
that referenced
this pull request
Jan 31, 2023
bmoran17
added a commit
to bmoran17/javascript-exercises
that referenced
this pull request
Feb 19, 2023
…t pass all tests
ericoptorres
added a commit
to ericoptorres/javascript-exercises-odin
that referenced
this pull request
Mar 24, 2023
danielrsouza10
added a commit
to danielrsouza10/javascript-exercises
that referenced
this pull request
Apr 2, 2023
NeilMartinRobertson
added a commit
to NeilMartinRobertson/javascript-exercises
that referenced
this pull request
Apr 6, 2023
gavinberetvas
pushed a commit
to gavinberetvas/javascript-exercises
that referenced
this pull request
Apr 20, 2023
KyleS115
added a commit
to KyleS115/javascript-exercises
that referenced
this pull request
Jun 16, 2023
ZorahScope
added a commit
to ZorahScope/top-javascript-exercises
that referenced
this pull request
Jun 27, 2023
colincherney
added a commit
to colincherney/javascript-exercises
that referenced
this pull request
Jul 6, 2023
solipsisms
added a commit
to solipsisms/javascript-exercises
that referenced
this pull request
Jul 23, 2023
jcanoCS
added a commit
to jcanoCS/javascript-exercises
that referenced
this pull request
Sep 14, 2023
Added a checking condition incase a parameter included a negative value to pass exercise 05 test TheOdinProject#4
jcanoCS
added a commit
to jcanoCS/javascript-exercises
that referenced
this pull request
Sep 14, 2023
A 'let' declaror was added to the convertToCelsius() function for robustness. Test TheOdinProject#4 failed since the convertToFahrenheit() function is not written yet.
hellogabor
added a commit
to hellogabor/javascript-exercises
that referenced
this pull request
Oct 18, 2023
robinreyescodes
added a commit
to robinreyescodes/javascript-exercises
that referenced
this pull request
Nov 9, 2023
joeyriosa
added a commit
to joeyriosa/javascript-exercises
that referenced
this pull request
Dec 17, 2023
phanwilkie
pushed a commit
to phanwilkie/javascript-exercises-v2
that referenced
this pull request
Jan 2, 2024
ibrahimcode85
added a commit
to ibrahimcode85/javascript-exercises
that referenced
this pull request
Jan 8, 2024
…of this exercise.
ibrahimcode85
added a commit
to ibrahimcode85/javascript-exercises
that referenced
this pull request
Jan 8, 2024
Jeff-livers
added a commit
to Jeff-livers/javascript-exercises
that referenced
this pull request
Feb 10, 2024
Smabian
added a commit
to Smabian/javascript-exercises
that referenced
this pull request
Feb 11, 2024
kvinchon
added a commit
to kvinchon/odin-js-exercises
that referenced
this pull request
Feb 23, 2024
jdlopez12
added a commit
to jdlopez12/javascript-exercises
that referenced
this pull request
Feb 25, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 5, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 5, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 12, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to change 'xit's in exercises like repeatString for testing exercise solutions was not immediately obvious. I felt it should be mentioned so newbies before me won't face confusing jasmine messages about xits when testing their code.
I don't know how the wording of the readme is really intended, so I hope my change will address this properly.