Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations: Object Basics: Bad Filter-Map-Reduce Visual #28696

Open
2 of 3 tasks
ruben-vl opened this issue Aug 24, 2024 · 6 comments
Open
2 of 3 tasks

Foundations: Object Basics: Bad Filter-Map-Reduce Visual #28696

ruben-vl opened this issue Aug 24, 2024 · 6 comments
Assignees
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues

Comments

@ruben-vl
Copy link
Contributor

ruben-vl commented Aug 24, 2024

Checks

Describe your suggestion

In the Object Basics lesson of the Foundations course, there is a visual for the filter/map/reduce array methods.

This image has some problems:

  • image resolution is quite bad
  • image quality is terrible (e.g. no centering, non-consistent arrows, ...)
  • the referenced url is cropped, making the original hard to find (I found a subset of the image here; i suspect someone hand-made the filter part (first arrow is obviously copied, with the shading of the cut bread image visible, and the font on filter being different)

Possible solutions:

  1. remake the diagram with some better pictures, proper centering, and a higher quality export (+ reference to the 'inspiration image' ofcourse)
  2. replace with a better visual for these three methods (+ reference)
  3. remove the image and provide a textual summary

I think option 2 is best, with option 3 as fallback, but I would love to hear your suggestions! I also wouldn't mind working on this, but if someone else is eager to work on a simple issue, by all means go ahead! :)

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-object-basics

(Optional) Discord Name

ruben-vl

(Optional) Additional Comments

No response

@MaoShizhong
Copy link
Contributor

Wouldn't be opposed to a higher resolution and neater equivalent, whether that's an alternative image we can attribute or a custom made one.

If you'd like to work on this, I can assign it to you. Handling images in lessons is a 2-PR process - one to replace the image file, a second to replace the CDN link for the image in the appropriate lesson, and any other alt text etc.

@mathdebate09
Copy link
Contributor

If OP doesn't have bandwidth rn, I can take this issue up

@ruben-vl
Copy link
Contributor Author

If OP doesn't have bandwidth rn, I can take this issue up

Go ahead, I don't have much time for it atm.

@MaoShizhong
Copy link
Contributor

Cheers both. Assigned, @mathdebate09

@mathdebate09
Copy link
Contributor

mathdebate09 commented Aug 26, 2024

objects

Res: 1780 x 1200

Made this using figma, let me know if any changes would be needed, or else i can submit a pr

Edit: Figma Link

Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues
Projects
None yet
Development

No branches or pull requests

3 participants