fails in replacing templateUrl with template #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2017 17:15
… templateUrl and leaves it as templateUrl: require() instead of template: require(), even when keepUrl is false
Codecov Report@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 1 1
Lines 28 28
Branches 5 5
=======================================
Hits 27 27
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding case insensitivity this fixes a bug where its not altering the templateUrl and leaves it as templateUrl: require() instead of template: require(), even when keepUrl is false.
Moving the space identifier \s* and adding one to styleUrls for unification.