Add static asserts to Xfer to invoke extra caution if certain type si… #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
force-pushed
the
remove-c-casts-07-xfer
branch
2 times, most recently
from
f5f7655 to
9706cbf
Compare
xezon
commented
Feb 19, 2022
| @@ -2970,7 +2970,6 @@ void W3DModelDraw::Xfer_Snapshot(Xfer *xfer) | |||
| if (anim) { | |||
| float frame; | |||
| int frames; | |||
| int mode; | |||
There was a problem hiding this comment.
This looks like an error. int mode was shadowing the serialized mode from above.
xezon
force-pushed
the
remove-c-casts-07-xfer
branch
2 times, most recently
from
f6cfc19 to
1889dca
Compare
|
Instead of having only some using the correct size types I propose we just switch the codebase in full one type at a time it will lead to more consistent code #606 |
…zes suddenly deviate from the norm
xezon
force-pushed
the
remove-c-casts-07-xfer
branch
from
1889dca to
936bcda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zes suddenly deviate from the norm