Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Broken links #142

Closed
siriak opened this issue Nov 24, 2021 · 12 comments
Closed

[BUG] Broken links #142

siriak opened this issue Nov 24, 2021 · 12 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@siriak
Copy link
Member

siriak commented Nov 24, 2021

Description of the bug

Description
Code implementation links of algorithms when opened are giving 404 errors. I observed such behavior for Bubble sort.

Actual behavior

  1. Go to https://the-algorithms.com/algorithm/bubble-sort
  2. Scroll down to Code Implementation links
  3. Click on Java

Actual behavior
4. See Github 404 page (the link is https://github.com/TheAlgorithms/Java/blob/master/Sorts/BubbleSort.java)

Expected behavior
4. Bubble sort page should open (the link is https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BubbleSort.java)

Add screenshots of the bug (if applicable)

No response

Additional information/context

Originally reported here TheAlgorithms/Java#2840

@maltejur
Copy link
Collaborator

maltejur commented Nov 24, 2021

All of those links in the explanations are hardcoded into https://github.com/TheAlgorithms/Algorithms-Explanation, so they would have to be updated there.

@Tejas-Teju
Copy link

Anyone working on this issue?

@maltejur
Copy link
Collaborator

maltejur commented Nov 24, 2021

The wrong links in https://github.com/TheAlgorithms/Algorithms-Explanation are still there and I currently don't have the time to fix them.

@mgncodes
Copy link

Hi, I'd like to contribute to this issue. Kindly assign to me. Thanks!

@maltejur
Copy link
Collaborator

Sure

@Panquesito7 Panquesito7 added the good first issue Good for newcomers label Dec 13, 2021
@mgncodes
Copy link

Hi @maltejur, I have a doubt.
The link for code implementation is changed in the issue mentioned by @Panquesito7 , but the PR made in that issue is still not merged, so it is still not updated in Algorithms-Explanation repo.
Is it like, if the links in Algorithms-Explanation repo is updated, then only the changes in the link will be reflected here?
Kindly clarify.

@maltejur
Copy link
Collaborator

As the comment in that PR already says, the pull request only fixed two links, but every java link in that repository is broken. So it would be great to just have another PR in Algorithms-Explanation where all the links are fixed.

@sambhavsaxena
Copy link

sambhavsaxena commented Jan 27, 2022

@siriak @maltejur I have the code ready on my fork, raising a PR real quick.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 27, 2022
@Panquesito7 Panquesito7 removed the stale label Apr 27, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@Panquesito7 Panquesito7 removed the stale label Jul 15, 2022
@riyaz2014
Copy link

Hello I would like to contribute contribute to this issue. Kindly assign it to me please

@Panquesito7
Copy link
Member

Closing as this should be fixed upstream at https://github.com/TheAlgorithms/Algorithms-Explanation

@Panquesito7 Panquesito7 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants