Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimization of while loop in Armstrong Numbers #9976

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Minimization of while loop in Armstrong Numbers #9976

merged 2 commits into from
Oct 16, 2023

Conversation

Dwarkadhish2005
Copy link
Contributor

The while loop is removed and simple length calculation is used so the task of minimization of while loop is achieved

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER". Minimization of while loop in Armstrong Numbers #9968

@Dwarkadhish2005
Minimization of while loop in Armstrong Numbers
9dde9ab 
The while loop is removed and simple length calculation is used so the task of minimization of while loop is achieved
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 7, 2023
Dwarkadhish2005
Dwarkadhish2005 commented Oct 7, 2023
View reviewed changes
Copy link
Contributor Author

@Dwarkadhish2005 Dwarkadhish2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code changes fixes all the problem explained that is the minimization of while loop by replacing it by length calculation in armstrong number and so it is all fit to pass review and merge.

Dwarkadhish2005
Dwarkadhish2005 commented Oct 7, 2023
View reviewed changes
Copy link
Contributor Author

@Dwarkadhish2005 Dwarkadhish2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the code is approved please merge it

@haxkd
Copy link
Contributor

haxkd commented Oct 7, 2023

the write access reviewer will merge it soon.

@tianyizheng02 tianyizheng02 linked an issue Oct 7, 2023 that may be closed by this pull request
Minimization of while loop in Armstrong Numbers #9968
Closed
@tianyizheng02
Copy link
Contributor

@lohith-lalam This PR calculates the number of digits using len(str(n)) instead of log10(n) + 1. Do you prefer your original method? Or do you prefer this one?

@Dwarkadhish2005
Copy link
Contributor Author

i prefer my original changed code as it is simple to process and no unnecessary complications

@Dwarkadhish2005
Copy link
Contributor Author

the reviewers have not yet merged my code ...please take this in consideration as soon as possible

tianyizheng02
tianyizheng02 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this over the log10 method because the latter can be incorrect if n is too large (due to the limitations of floating-point numbers)

@tianyizheng02 tianyizheng02 merged commit 69707bf into TheAlgorithms:master Oct 16, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2023
This was referenced Oct 16, 2023
Closed
Closed
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Dwarkadhish2005 @pre-commit-ci @sedatguzelsemme
Minimization of while loop in Armstrong Numbers (TheAlgorithms#9976)
e3d9340 
* Minimization of while loop in Armstrong Numbers

The while loop is removed and simple length calculation is used so the task of minimization of while loop is achieved

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haxkd haxkd haxkd approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimization of while loop in Armstrong Numbers
3 participants
@Dwarkadhish2005 @haxkd @tianyizheng02