Add Flake8 F4 Tests to .travis.yml #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4 tests check for import errors. Implements issue TheAlgorithms#973
|
Another approach is to do smaller PRs... Like a PR that just adds F401 to .travis.yml and fixes the three instances of that. Another PR that adds F403 and fixes the two instance of that. Small moves. |
|
Should we progress this one or close it? |
|
I think we should progress. Checking for import errors can be helpful in the future, not just now. |
cclauss
approved these changes
Sep 13, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add Flake8 F4 Tests to .travis.yml F4 tests check for import errors. Implements issue TheAlgorithms#973 * Remove wildcard imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F4 tests check for import errors. Implements issue #973