Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Comments #9668

Merged
merged 23 commits into from
Oct 4, 2023
Merged

Add Comments #9668

merged 23 commits into from
Oct 4, 2023

Conversation

SiddhantTotade
Copy link
Contributor

Describe your change:

Few files does not have any comments so I added it.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 4, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 4, 2023
cclauss
cclauss requested changes Oct 4, 2023
View reviewed changes
data_structures/linked_list/circular_linked_list.py Outdated Show resolved Hide resolved
data_structures/linked_list/circular_linked_list.py Outdated Show resolved Hide resolved
data_structures/linked_list/circular_linked_list.py Outdated Show resolved Hide resolved
data_structures/linked_list/circular_linked_list.py Show resolved Hide resolved
data_structures/linked_list/circular_linked_list.py Show resolved Hide resolved
data_structures/linked_list/swap_nodes.py Outdated Show resolved Hide resolved
data_structures/linked_list/swap_nodes.py Outdated Show resolved Hide resolved
data_structures/linked_list/swap_nodes.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
data_structures/linked_list/swap_nodes.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 4, 2023
@SiddhantTotade @cclauss
Update data_structures/linked_list/circular_linked_list.py
2288708 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 4, 2023
SiddhantTotade and others added 7 commits October 4, 2023 14:43
@SiddhantTotade @cclauss
Update data_structures/linked_list/circular_linked_list.py
fa3b858 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update data_structures/linked_list/swap_nodes.py
a918ca5 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update data_structures/linked_list/swap_nodes.py
6366b17 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update data_structures/linked_list/swap_nodes.py
01352c8 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update data_structures/linked_list/swap_nodes.py
dea9a9f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update requirements.txt
74a5ddc 
Co-authored-by: Christian Clauss <cclauss@me.com>
@SiddhantTotade @cclauss
Update data_structures/linked_list/circular_linked_list.py
61a9e05 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023
@cclauss cclauss enabled auto-merge (squash) October 4, 2023 09:24
@cclauss cclauss merged commit 3fd3497 into TheAlgorithms:master Oct 4, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
@tianyizheng02 tianyizheng02 mentioned this pull request Oct 4, 2023
Merged
14 tasks
@Arunsiva003 Arunsiva003 mentioned this pull request Oct 4, 2023
Closed
@SiddhantTotade SiddhantTotade deleted the python-hacktober-2023 branch October 8, 2023 09:52
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@SiddhantTotade @pre-commit-ci
@cclauss @sedatguzelsemme
Add Comments (TheAlgorithms#9668)
db800f9 
* docs : add comment in circular_linked_list.py and swap_nodes.py

* docs : improve comments

* docs : improved docs and tested on pre-commit

* docs : add comment in circular_linked_list.py and swap_nodes.py

* docs : improve comments

* docs : improved docs and tested on pre-commit

* docs : modified comments

* Update circular_linked_list.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* docs : improved

* Update data_structures/linked_list/circular_linked_list.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/circular_linked_list.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/swap_nodes.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/swap_nodes.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/swap_nodes.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/swap_nodes.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update requirements.txt

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/circular_linked_list.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update circular_linked_list.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiddhantTotade @cclauss