Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all implementations of n queens into one file #9664

Closed
wants to merge 4 commits into from

Conversation

Mallik0
Copy link

@Mallik0 Mallik0 commented Oct 4, 2023

Describe your change:

This PR moves all implementations of n queens concepts into one file named all_n_queens.py, which includes n_queens.py, n_queens_math.py, and sudoku.py which are all the implementations of n queens concept moved into one single file

Fixes #8098

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please organize and clean up the implementations rather than simply copy-pasting them into the one file one after the other.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that sudoku is a distinct enough problem that it shouldn't be lumped with the other n-queens implementations.

@cclauss
Copy link
Member

cclauss commented Sep 30, 2024

Closing tests_are_failing PRs to prepare for Hacktoberfest 2024.

@cclauss cclauss closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations
3 participants