Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of base32.py algorithm #9068

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Rewrite of base32.py algorithm #9068

merged 4 commits into from
Sep 24, 2023

Conversation

ChrisO345
Copy link
Collaborator

@ChrisO345 ChrisO345 commented Sep 20, 2023 •
edited
Loading

Describe your change:

Fixes #8966
Fixes #8965

See #6216

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 20, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Sep 20, 2023
@CaedenPH
Copy link
Contributor

@ChrisO345 Put fixes #8965 in the description please

@rohan472000
Copy link
Contributor

Now build will pass as #9078 is merged.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 23, 2023
tianyizheng02
tianyizheng02 requested changes Sep 24, 2023
View reviewed changes
ciphers/base32.py Outdated Show resolved Hide resolved
ciphers/base32.py Outdated Show resolved Hide resolved
ciphers/base32.py Outdated Show resolved Hide resolved
@ChrisO345 @tianyizheng02
Apply suggestions from code review
89e2c4b 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@tianyizheng02 tianyizheng02 merged commit 53a51b3 into TheAlgorithms:master Sep 24, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 24, 2023
@tianyizheng02
Copy link
Contributor

@ChrisO345 Thanks for the rewrite!

@ChrisO345 ChrisO345 deleted the base32 branch September 24, 2023 06:15
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@ChrisO345 @tianyizheng02 @sedatguzelsemme
Rewrite of base32.py algorithm (TheAlgorithms#9068)
7d3d254 
* rewrite of base32.py

* changed maps to list comprehension

* Apply suggestions from code review

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisO345 @CaedenPH @rohan472000 @tianyizheng02