Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continued_fraction.py to work for negative numbers #8985

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Fix continued_fraction.py to work for negative numbers #8985

merged 3 commits into from
Aug 18, 2023

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Aug 18, 2023 •
edited
Loading

Describe your change:

  • Per comment on Added Continued fractions #6846, I've added doctests to continued_fractions.py for 0 and negative numbers
  • Fixed the implementation to work for negative numbers by replacing int() call with floor(): the algorithm requires a rounding down to the nearest int, but int() rounds to 0, not down
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 18, 2023
@tianyizheng02
Fix continued_fraction.py to work for negative nums
19bd379 
Fix continued_fraction.py to work for negative nums by replacing int() call with floor()
@tianyizheng02 tianyizheng02 changed the title Add doctests to continued_fraction.py for 0 and negative numbers Fix continued_fraction.py to work for negative numbers Aug 18, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Aug 18, 2023
@tianyizheng02 tianyizheng02 mentioned this pull request Aug 18, 2023
Merged
14 tasks
@tianyizheng02 tianyizheng02 requested a review from cclauss August 18, 2023 03:48
CaedenPH
CaedenPH approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@cclauss cclauss merged commit e887c14 into TheAlgorithms:master Aug 18, 2023
@tianyizheng02 tianyizheng02 deleted the cont-frac-tests branch August 18, 2023 21:20
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Fix continued_fraction.py to work for negative numbers (TheAlgorithms…
68dbc0a 
…#8985)

* Add doctests to continued_fraction.py for 0 and neg nums

* Fix continued_fraction.py to work for negative nums

Fix continued_fraction.py to work for negative nums by replacing int() call with floor()

* Move comment in doctest
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyizheng02 @cclauss @CaedenPH