Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable quantum/quantum_random.py (attempt 2) #8902

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Disable quantum/quantum_random.py (attempt 2) #8902

merged 3 commits into from
Jul 28, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Temporarily disable quantum/quantum_random.py because it produces an illegal instruction error that causes all builds to fail (see #8899)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02 and others added 3 commits July 28, 2023 12:51
@tianyizheng02
Disable quantum/quantum_random.py
08c4fcd 
Temporarily disable quantum/quantum_random.py because it produces an illegal instruction error that causes all builds to fail
updating DIRECTORY.md
4194202
@tianyizheng02
Disable quantum/quantum_random.py attempt 2
642c885
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 28, 2023
@tianyizheng02
Copy link
Contributor Author

@cclauss Could you merge to fix the failing builds?

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 28, 2023
@cclauss cclauss merged commit 0ef9306 into TheAlgorithms:master Jul 28, 2023
2 checks passed
@tianyizheng02 tianyizheng02 deleted the disable-q-rand branch July 28, 2023 20:10
@cclauss
Copy link
Member

cclauss commented Jul 30, 2023

I hope that you got an invitation to join TheAlgorithms. I could really use your help as a maintainer to clean up our pull requests ahead of Octoberfest.

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Disable quantum/quantum_random.py (attempt 2) (TheAlgorithms#8902)
0c9b6fe 
* Disable quantum/quantum_random.py

Temporarily disable quantum/quantum_random.py because it produces an illegal instruction error that causes all builds to fail

* updating DIRECTORY.md

* Disable quantum/quantum_random.py attempt 2

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @cclauss