Fix simplex.py #8843
Merged
Fix simplex.py #8843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
|
Having found an error in the course that taught this simplex algorithm, I ask you to review my changes once more, @cclauss |
cclauss
reviewed
Jul 22, 2023
cclauss
reviewed
Jul 22, 2023
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
added
tests are failing
|
@CaedenPH sorry about the number of commits; I had issues with ruff etc. Could you please check this version? |
|
To clarify, the old version couldn't optimally solve certain problems like the one I inserted on lines 270-286 in a doctest. I only realised this after that version was merged, given that it is a rare case. I adapted the implementation of other courses to fix this issue, but took the opportunity to add more doctests and checks. |
CaedenPH
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Nice change, thanks for adding the extra doctests.
@tianyizheng02 Pinging for review
tianyizheng02
approved these changes
Aug 17, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* changes to accommodate special case * changed n_slack calculation method * fix precommit typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * n_art_vars inputs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: docstrings and typehints * fix: doctest issues when running code * additional check and doctests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix ruff * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix whitespace --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
I discovered that the algorithm I used initially gives suboptimal solutions when a pivot on a slack column is required; the algorithm terminates prematurely.
This pull request changes function inputs and doctests to reflect changes made to the steps of the algorithm. Mainly:
Checklist: