Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project Euler problem 187 solution 1 #8182

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Add Project Euler problem 187 solution 1:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Mar 15, 2023
@dhruvmanila
Copy link
Member

Any way this could be optimized? It's taking roughly 22 seconds.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 23, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 23, 2023
@MaximSmolskiy
Copy link
Member Author

Any way this could be optimized? It's taking roughly 22 seconds.

@dhruvmanila I optimized solution (used the fact that least prime number is 2, so the greatest prime number should be less than max_number / 2)

P. S. Now I have issues with ruff check, but it seems that it isn't related to this PR

@MaximSmolskiy
Copy link
Member Author

@dhruvmanila please merge, failed checks were fixed by merging with master branch

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 28, 2023
@dhruvmanila
Copy link
Member

Merging it as it is, still taking roughly 7 seconds! I'll open an issue for this if someone wants to take a stab at it.

@dhruvmanila dhruvmanila merged commit dc4f603 into TheAlgorithms:master Apr 1, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Apr 1, 2023
@MaximSmolskiy MaximSmolskiy deleted the add-project-euler-problem-187-solution-1 branch April 1, 2023 06:14
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants