Graham's Law #8162
Merged
Graham's Law #8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
physics/grahams_law.py
Outdated
| from math import pow, sqrt | ||
|
|
||
|
|
||
| def validate(*values) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/grahams_law.py, please provide doctest for the function validate
Please provide type hint for the parameter: values
algorithms-keeper
bot
added
tests are failing
algorithms-keeper
bot
removed
the
tests are failing
cclauss
reviewed
Feb 28, 2023
| -------- | ||
| >>> validate(2.016, 4.002) | ||
| True | ||
| >>> validate(-2.016, 4.002) |
There was a problem hiding this comment.
Please add a test for
>>> validate(2.016, -4.002)
and explain why it returns the wrong result.
Python's builtin all() or any() might be a better fit.
There was a problem hiding this comment.
Hello @cclauss thank you for your feedback. I just pushed up changes to address this test case. I also added value errors to explain why this test returns False
cclauss
approved these changes
Apr 1, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
* grahams law * doctest and type hints * doctest formatting * peer review updates
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* grahams law * doctest and type hints * doctest formatting * peer review updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.