Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #6348

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Update README.md #6348

merged 1 commit into from
Sep 9, 2022

Conversation

nikhilkala
Copy link
Member

@nikhilkala nikhilkala commented Sep 4, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Sep 4, 2022
Panquesito7
Panquesito7 reviewed Sep 8, 2022
View reviewed changes
README.md
@@ -12,9 +12,6 @@
<a href="https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md">
<img src="https://img.shields.io/static/v1.svg?label=Contributions&message=Welcome&color=0059b3&style=flat-square" height="20" alt="Contributions Welcome">
</a>
<a href="https://www.paypal.me/TheAlgorithms/100">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a link to our Liberapay page instead?

__
sema-logo  Summary: ❓ I have a question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed with Anup, Readme shouldn't have any donate options.

LordReydrX
LordReydrX approved these changes Sep 9, 2022
View reviewed changes
Copy link

@LordReydrX LordReydrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it meets the requirements to me.

@nikhilkala nikhilkala removed the request for review from AnupKumarPanwar September 9, 2022 08:03
Panquesito7
Panquesito7 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 9, 2022
@Panquesito7 Panquesito7 merged commit 4e4fe95 into master Sep 9, 2022
@Panquesito7 Panquesito7 deleted the readme-update branch September 9, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordReydrX LordReydrX LordReydrX approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilkala @Panquesito7 @LordReydrX