Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase g --> Capital G #5845

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Lowercase g --> Capital G #5845

merged 4 commits into from
Nov 24, 2021

Conversation

GoodnessEzeh
Copy link
Contributor

Describe your change: Updated comments on the .gitignore file.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 24, 2021
cclauss
cclauss approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this in upstream https://github.com/github/gitignore/blob/master/Python.gitignore

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 24, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 24, 2021
@cclauss cclauss changed the title Updated comments on the .gitignore file. Lowercase g --> Capital G Nov 24, 2021
@GoodnessEzeh
Copy link
Contributor Author

Just did it.

@cclauss cclauss merged commit f4a16f6 into TheAlgorithms:master Nov 24, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodnessEzeh @cclauss