Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Quine–McCluskey algorithm #4935

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Conversation

RenatoLopes771
Copy link
Contributor

Describe your change:

I made some variables more descriptive on simple functions and changed some syntax of the following (inside Booleans):

`
return 1 == 1

instead of

if 1 == 1:
return True
else:
return False
`

and

`
while True:

instead of

while 1
`

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • [] All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 3, 2021
@poyea poyea self-assigned this Oct 4, 2021
@poyea
Copy link
Member

poyea commented Oct 4, 2021

@algorithms-keeper review

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Even better if you can add some comments + extra tests to these functions too.

@poyea poyea changed the title Syntax improvements (I hope) to boolean algebra Improve Quine–McCluskey algorithm Oct 4, 2021
@RenatoLopes771
Copy link
Contributor Author

@poyea Made the requested changes, though I had a question on one of them if you could answer.

@RenatoLopes771
Copy link
Contributor Author

@poyea Made the final requested changes, hopefully everything should be resolved now.

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 27, 2021
@poyea poyea added the awaiting merge This PR is approved and ready to be merged label Oct 27, 2021
@poyea poyea merged commit 9af2eef into TheAlgorithms:master Dec 16, 2021
@ghost ghost removed the awaiting merge This PR is approved and ready to be merged label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants