-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Quine–McCluskey algorithm #4935
Conversation
@algorithms-keeper review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Even better if you can add some comments + extra tests to these functions too.
@poyea Made the requested changes, though I had a question on one of them if you could answer. |
@poyea Made the final requested changes, hopefully everything should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
Describe your change:
I made some variables more descriptive on simple functions and changed some syntax of the following (inside Booleans):
`
return 1 == 1
instead of
if 1 == 1:
return True
else:
return False
`
and
`
while True:
instead of
while 1
`
Checklist:
Fixes: #{$ISSUE_NO}
.