Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Use a --exclude list #4296

Merged
merged 5 commits into from
Mar 31, 2021
Merged

mypy: Use a --exclude list #4296

merged 5 commits into from
Mar 31, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 27, 2021 •
edited
Loading

Related to #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improve continuous integration testing

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner March 27, 2021 18:56
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 27, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Mar 27, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 27, 2021
@dhruvmanila dhruvmanila merged commit c22c7d5 into TheAlgorithms:master Mar 31, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 31, 2021
@cclauss cclauss deleted the mypy-excludes branch March 31, 2021 05:12
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@cclauss @peRFectBeliever
mypy: Use a --exclude list (TheAlgorithms#4296)
6530b10 
* mypy: Use a --exclude list

* Graphics works on my machine

* A few more...

* A few more...

* Update build.yml
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss
mypy: Use a --exclude list (TheAlgorithms#4296)
0636343 
* mypy: Use a --exclude list

* Graphics works on my machine

* A few more...

* A few more...

* Update build.yml
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
mypy: Use a --exclude list (TheAlgorithms#4296)
3d02e46 
* mypy: Use a --exclude list

* Graphics works on my machine

* A few more...

* A few more...

* Update build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila