Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.yml: Run mypy --ignore-missing-imports #4276

Merged
merged 4 commits into from
Mar 20, 2021
Merged

build.yml: Run mypy --ignore-missing-imports #4276

merged 4 commits into from
Mar 20, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 20, 2021

Describe your change:

An alternative to #4274

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner March 20, 2021 05:34
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 20, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Mar 20, 2021
@dhruvmanila
Copy link
Member

It seems that type hints for files in the directories: digital_image_processing and arithmetic_analysis are incorrect. We should remove them for now.

@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 20, 2021
@cclauss cclauss mentioned this pull request Mar 20, 2021
Closed
15 tasks
dhruvmanila
dhruvmanila reviewed Mar 20, 2021
View reviewed changes
.github/workflows/build.yml Outdated
python -m pip install pytest-cov -r requirements.txt
python -m pip install mypy pytest-cov -r requirements.txt
# FIXME: #4052 fix mypy errors in other directories and add them here
- run: python3 -m mypy --ignore-missing-imports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any need for calling mypy using the Python interpreter as mypy has its own entrypoint.

dhruvmanila
dhruvmanila approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
@cclauss cclauss merged commit 8d7ef6a into master Mar 20, 2021
@cclauss cclauss deleted the build.yml-Run-mypy---ignore-missing-imports branch March 20, 2021 06:01
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@cclauss @peRFectBeliever
build.yml: Run mypy --ignore-missing-imports (TheAlgorithms#4276)
bc090d8 
* build.yml: Run mypy --ignore-missing-imports

* pip install mypy

* Remove failing directories

* Add fractals and drop python-m
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss
build.yml: Run mypy --ignore-missing-imports (TheAlgorithms#4276)
70e3c34 
* build.yml: Run mypy --ignore-missing-imports

* pip install mypy

* Remove failing directories

* Add fractals and drop python-m
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
build.yml: Run mypy --ignore-missing-imports (TheAlgorithms#4276)
bbf0bc9 
* build.yml: Run mypy --ignore-missing-imports

* pip install mypy

* Remove failing directories

* Add fractals and drop python-m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila