Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub action only for Project Euler #3378

Merged
merged 7 commits into from
Oct 17, 2020

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 16, 2020

Describe your change:

Move Project Euler tests to GitHub actions.

Reason:

Testing the Project Euler directory even if there's no change in any of its files is a pretty waste of time and energy. Travis CI doesn't provide the ability to test only if some files are changed but GitHub actions do. Both jobs will only run if any of the files within the project_euler directory is changed and this action file.

Status:

  • GitHub action performing as expected
    • Run only if the specified files change
    • Don't run if any other files change
  • Remove # from .travis.yml

@dhruvmanila dhruvmanila requested a review from cclauss as a code owner October 16, 2020 11:19
@dhruvmanila dhruvmanila changed the title Pe gh action Create GitHub action only for Project Euler Oct 16, 2020
@dhruvmanila dhruvmanila marked this pull request as draft October 16, 2020 11:22
@dhruvmanila dhruvmanila marked this pull request as ready for review October 16, 2020 11:31
@dhruvmanila dhruvmanila added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 16, 2020
@dhruvmanila
Copy link
Member Author

Proposal:

We can do the same thing where the job without Project Euler runs only if any of the files in the directories except for project_euler is changed.

@dhruvmanila dhruvmanila requested review from cclauss and removed request for cclauss October 16, 2020 17:42
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always.

@dhruvmanila dhruvmanila merged commit 5cb41e7 into TheAlgorithms:master Oct 17, 2020
@dhruvmanila dhruvmanila deleted the pe-gh-action branch October 17, 2020 05:23
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Add GitHub action for Project Euler only

* Add second job for Project Euler

* Remove Project Euler jobs from Travis CI

* Fix typo for actions/setup-python

* Rename the workflow file

* Change name of file in workflow

* Remove comments from Travis config file
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Add GitHub action for Project Euler only

* Add second job for Project Euler

* Remove Project Euler jobs from Travis CI

* Fix typo for actions/setup-python

* Rename the workflow file

* Change name of file in workflow

* Remove comments from Travis config file
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Add GitHub action for Project Euler only

* Add second job for Project Euler

* Remove Project Euler jobs from Travis CI

* Fix typo for actions/setup-python

* Rename the workflow file

* Change name of file in workflow

* Remove comments from Travis config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants