Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BROKEN BUILD: Fix a failing precommit test #3344

Merged
merged 2 commits into from
Oct 15, 2020
Merged

BROKEN BUILD: Fix a failing precommit test #3344

merged 2 commits into from
Oct 15, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss changed the title Fix a failing precommit test BROKEN BUILD: Fix a failing precommit test Oct 15, 2020
@Panquesito7 Panquesito7 added the enhancement This PR modified some existing files label Oct 15, 2020
Panquesito7
Panquesito7 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; good work. 👍

@cclauss cclauss merged commit 5b024f4 into master Oct 15, 2020
@cclauss cclauss deleted the cclauss-patch-1 branch October 15, 2020 22:33
@Panquesito7 Panquesito7 added the awaiting merge This PR is approved and ready to be merged label Oct 15, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
BROKEN BUILD: Fix a failing precommit test (TheAlgorithms#3344)
64750ee 
* Fix a failing precommit test

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss
BROKEN BUILD: Fix a failing precommit test (TheAlgorithms#3344)
d3ad48d 
* Fix a failing precommit test

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees

@poyea poyea

@realDuYuanChao realDuYuanChao

@l3str4nge l3str4nge

@Panquesito7 Panquesito7

@dhruvmanila dhruvmanila

Labels
awaiting merge This PR is approved and ready to be merged enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cclauss @Panquesito7 @poyea @realDuYuanChao @l3str4nge @dhruvmanila