Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Euler 57 - Square root convergents #3259

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Project Euler 57 - Square root convergents #3259

merged 4 commits into from
Oct 16, 2020

Conversation

bh2smith
Copy link
Contributor

Describe your change:

This PR addresses issue #2695 and adds a solution to Project Euler Problem 57 - "Square root convergents"

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
    Created new directory for previously non-existent Project Euler solution
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
    Doesn't seem relevant
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@bh2smith

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@bh2smith
Copy link
Contributor Author

Thanks @dhruvmanila for the feedback, I have updated the solution to comply with the new guidelines. In particular,

  • Renamed directory to have 3 digits for problem number.
  • Included link to the original problem and
  • removed the value for input in the main method.

Please let me know if anything else looks off! Cheers 🥂

dhruvmanila
dhruvmanila reviewed Oct 16, 2020
View reviewed changes
project_euler/problem_057/sol1.py Outdated
Comment on lines 34 to 35
a, b = 1, 1
res = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptive variable names would be awesome to work with :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I have made the replacements

a -> prev_numerator
b -> prev_denominator
res -> result

@dhruvmanila dhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 16, 2020
@bh2smith bh2smith requested a review from dhruvmanila October 16, 2020 15:38
dhruvmanila
dhruvmanila approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit 5887567 into TheAlgorithms:master Oct 16, 2020
@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 16, 2020
@bh2smith
Copy link
Contributor Author

Thank you for your contribution!

I've got plenty more coming your way! Also hope to contribute to the Rust Project Euler Solutions as well.

@bh2smith bh2smith deleted the project_euler_57 branch October 16, 2020 16:02
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@bh2smith @stokhos
Project Euler 57 - Square root convergents (TheAlgorithms#3259)
5c86853 
* include solution for problem 57

* fix line to long errors

* update filenames and code to comply with new regulations

* more descriptive local variables
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@bh2smith @peRFectBeliever
Project Euler 57 - Square root convergents (TheAlgorithms#3259)
4db79cb 
* include solution for problem 57

* fix line to long errors

* update filenames and code to comply with new regulations

* more descriptive local variables
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@bh2smith
Project Euler 57 - Square root convergents (TheAlgorithms#3259)
a11c7df 
* include solution for problem 57

* fix line to long errors

* update filenames and code to comply with new regulations

* more descriptive local variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bh2smith @dhruvmanila