Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in the evaluate postfix notation using Stack #2598

Merged
merged 12 commits into from
Oct 16, 2020
Merged

Adding in the evaluate postfix notation using Stack #2598

merged 12 commits into from
Oct 16, 2020

Conversation

akashgkrishnan
Copy link
Contributor

@akashgkrishnan akashgkrishnan commented Oct 1, 2020 •
edited
Loading

Describe your change:

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@akashgkrishnan
Create evaluate_postfix_notations.py
c848c3c 
Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks
@akashgkrishnan
Create evaluate_postfix_notations.py
0ac6611 
Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks
@akashgkrishnan
Delete evaluate_postfix_notations.py
73f61b2
@poyea
Copy link
Member

poyea commented Oct 1, 2020

Please change the PR's title to something more meaningful.

@poyea poyea added the tests are failing Do not merge until tests pass label Oct 1, 2020
@akashgkrishnan
Evaluate postfix expression stack clean approach
e9334a1 
Sending in the PR again as the Previous request failed in pre commit
@akashgkrishnan akashgkrishnan changed the title Patch 6 Adding in the evaluate postfix notation using Stack Oct 1, 2020
@akashgkrishnan
Update evaluate_postfix_notations.py
7e1eb21 
Made changes as per the required for fixing the failing pre-commits.
cclauss
cclauss reviewed Oct 15, 2020
View reviewed changes
data_structures/stacks/evaluate_postfix_notations.py Outdated
@@ -1,12 +1,24 @@
'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called a docstring which explains the intent of this file. The docstring is used by pydoc if you run the command python3 -m pydoc data_structures/stacks/evaluate_postfix_notations.py

By converting this to a comment, this PR would remove that documentation.

@cclauss
Copy link
Member

cclauss commented Oct 15, 2020

https://docs.python.org/3/library/operator.html makes dealing with these probems much easier.

@akashgkrishnan
Update evaluate_postfix_notations.py
e1c15e9 
Made changes as suggested by @cclauss
@akashgkrishnan
Copy link
Contributor Author

thanks, @cclauss for the detailed review. However, pre commits are still failing. I'll update and recommit

@akashgkrishnan
Update evaluate_postfix_notations.py
2f63309 
Deleted trailing white spaces causing pre-commits to fail
akashgkrishnan and others added 2 commits October 16, 2020 16:47
@akashgkrishnan @cclauss
Update data_structures/stacks/evaluate_postfix_notations.py
29530ed 
Co-authored-by: Christian Clauss <cclauss@me.com>
@akashgkrishnan @cclauss
Update data_structures/stacks/evaluate_postfix_notations.py
22393cf 
Co-authored-by: Christian Clauss <cclauss@me.com>
@akashgkrishnan
Copy link
Contributor Author

@cclauss sir is there something else that needs to be fixed in this?

@cclauss cclauss merged commit 7d84f7f into TheAlgorithms:master Oct 16, 2020
@akashgkrishnan akashgkrishnan deleted the patch-6 branch October 17, 2020 02:02
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@akashgkrishnan @cclauss @stokhos
Adding in the evaluate postfix notation using Stack (TheAlgorithms#2598)
ab54d92 
* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Delete evaluate_postfix_notations.py

* Evaluate postfix expression stack clean approach

Sending in the PR again as the Previous request failed in pre commit

* Update evaluate_postfix_notations.py

* Update evaluate_postfix_notations.py

Made changes as per the required for fixing the failing pre-commits.

* Update evaluate_postfix_notations.py

Made changes as suggested by @cclauss

* Update evaluate_postfix_notations.py

fixed pre-commit fails

* Update evaluate_postfix_notations.py

fixing pre-commit fails

* Update evaluate_postfix_notations.py

Deleted trailing white spaces causing pre-commits to fail

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@akashgkrishnan @cclauss @peRFectBeliever
Adding in the evaluate postfix notation using Stack (TheAlgorithms#2598)
d612d9b 
* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Delete evaluate_postfix_notations.py

* Evaluate postfix expression stack clean approach

Sending in the PR again as the Previous request failed in pre commit

* Update evaluate_postfix_notations.py

* Update evaluate_postfix_notations.py

Made changes as per the required for fixing the failing pre-commits.

* Update evaluate_postfix_notations.py

Made changes as suggested by @cclauss

* Update evaluate_postfix_notations.py

fixed pre-commit fails

* Update evaluate_postfix_notations.py

fixing pre-commit fails

* Update evaluate_postfix_notations.py

Deleted trailing white spaces causing pre-commits to fail

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@akashgkrishnan @cclauss
Adding in the evaluate postfix notation using Stack (TheAlgorithms#2598)
7baf2af 
* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Create evaluate_postfix_notations.py

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

* Delete evaluate_postfix_notations.py

* Evaluate postfix expression stack clean approach

Sending in the PR again as the Previous request failed in pre commit

* Update evaluate_postfix_notations.py

* Update evaluate_postfix_notations.py

Made changes as per the required for fixing the failing pre-commits.

* Update evaluate_postfix_notations.py

Made changes as suggested by @cclauss

* Update evaluate_postfix_notations.py

fixed pre-commit fails

* Update evaluate_postfix_notations.py

fixing pre-commit fails

* Update evaluate_postfix_notations.py

Deleted trailing white spaces causing pre-commits to fail

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/stacks/evaluate_postfix_notations.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashgkrishnan @poyea @cclauss