Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated problem_04 in project_euler #2427

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Updated problem_04 in project_euler #2427

merged 4 commits into from
Sep 14, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Sep 14, 2020
View reviewed changes
project_euler/problem_04/sol1.py Outdated
Comment on lines 15 to 18
>>> solution(10000)
Traceback (most recent call last):
...
ValueError: No such latest palindrome number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's move this test below the others so we show how the function works before we show how it breaks,

cclauss
cclauss reviewed Sep 14, 2020
View reviewed changes
project_euler/problem_04/sol1.py Outdated
return number
divisor -= 1
raise ValueError("No such latest palindrome number.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is incorrect. It is not the the number does not exist, it is that it is larger than our acceptable range.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an error message ？ Thanks

@realDuYuanChao
Copy link
Member Author

Why we need change 3 to 3.0 like this
if (number % divisor == 0) and (len(str(number // divisor)) == 3.0): Thanks 😊

@cclauss cclauss merged commit cbbc43b into TheAlgorithms:master Sep 14, 2020
@cclauss
Copy link
Member

cclauss commented Sep 14, 2020

Given that 3 == 3.0, it is not necessary but...

>>> 9 // 3
3
>>> 9.3 // 3.1
3.0
>>> 9 // 3.0
3.0
>>> 9.0 // 3
3.0

@realDuYuanChao realDuYuanChao deleted the dev branch September 16, 2020 14:26
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Updated problem_04 in project_euler (TheAlgorithms#2427)
da4ac2c 
* Updated problem_04 in project_euler

* fixup! Format Python code with psf/black push

* That number is larger than our acceptable range.

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realDuYuanChao @cclauss