Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ruff SIM102 rule #11341

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Enable ruff SIM102 rule #11341

merged 4 commits into from
Apr 2, 2024

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Enable ruff SIM102 rule

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@MaximSmolskiy MaximSmolskiy requested a review from cclauss as a code owner April 1, 2024 20:59
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 1, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Apr 1, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 1, 2024
@cclauss
Copy link
Member

cclauss commented Apr 1, 2024

I actually question the value of this rule when I look these changes. Most take more lines than the original code.

What do you think?

1 similar comment
@cclauss
Copy link
Member

cclauss commented Apr 1, 2024

I actually question the value of this rule when I look these changes. Most take more lines than the original code.

What do you think?

@MaximSmolskiy
Copy link
Member Author

I'm generally neutral to both options, so I'm ready to accept any of them.
But for me this rule makes sense - it's more readable if every condition on its own line (it happens that way often due to several conditions, long line and formatter) and all conditions in one logical block instead of nested conditions.

@cclauss cclauss enabled auto-merge (squash) April 2, 2024 01:26
cclauss
cclauss approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s go for it…

@cclauss cclauss merged commit 93fb555 into TheAlgorithms:master Apr 2, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2024
@MaximSmolskiy MaximSmolskiy deleted the enable-ruff-SIM102-rule branch April 2, 2024 05:03
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@MaximSmolskiy @pre-commit-ci @sedatguzelsemme
Enable ruff SIM102 rule (TheAlgorithms#11341)
b034310 
* Enable ruff SIM102 rule

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @cclauss