Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff format as the pre-commit formatter #11247

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Use ruff format as the pre-commit formatter #11247

merged 4 commits into from
Jan 16, 2024

Conversation

ZJUGuoShuai
Copy link
Contributor

@ZJUGuoShuai ZJUGuoShuai commented Jan 16, 2024 •
edited by cclauss
Loading

Describe your change:

https://docs.astral.sh/ruff/formatter

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@ZJUGuoShuai ZJUGuoShuai requested a review from cclauss as a code owner January 16, 2024 02:09
@cclauss
Copy link
Member

cclauss commented Jan 16, 2024 •
edited
Loading

Let’s use the ruff formatter instead. It is written in Rust and will be much faster.

@cclauss cclauss reopened this Jan 16, 2024
@cclauss cclauss enabled auto-merge (squash) January 16, 2024 08:38
@cclauss cclauss changed the title Use compiled black as the pre-commit formatter Use ruff format as the pre-commit formatter Jan 16, 2024
cclauss
cclauss approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit 4b6f688 into TheAlgorithms:master Jan 16, 2024
@cclauss cclauss mentioned this pull request Jan 16, 2024
Closed
16 tasks
@ZJUGuoShuai ZJUGuoShuai deleted the black-pre-commit-hook branch January 16, 2024 08:57
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@ZJUGuoShuai @cclauss
@pre-commit-ci @sedatguzelsemme
Use compiled black as the pre-commit formatter (TheAlgorithms#11247)
c06bd90 
* Use compiled black as the pre-commit formatter

* ruff-format

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Keep GitHub Actions up to date with Dependabot

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZJUGuoShuai @cclauss