Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Josephus Problem #10928

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Add Josephus Problem #10928

merged 6 commits into from
Oct 29, 2023

Conversation

aqib-m31
Copy link
Contributor

@aqib-m31 aqib-m31 commented Oct 25, 2023 •
edited
Loading

Describe your change:

Added Josephus Problem.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 25, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 25, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/josephus_problem.py Outdated Show resolved Hide resolved
maths/josephus_problem.py Outdated Show resolved Hide resolved
maths/josephus_problem.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 25, 2023
@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 25, 2023
@aqib-m31
Copy link
Contributor Author

@tianyizheng02

cclauss
cclauss reviewed Oct 27, 2023
View reviewed changes
maths/josephus_problem.py Outdated Show resolved Hide resolved
@aqib-m31 aqib-m31 mentioned this pull request Oct 29, 2023
Merged
15 tasks
@cclauss cclauss added the awaiting changes A maintainer has requested changes to this PR label Oct 29, 2023
@cclauss cclauss self-assigned this Oct 29, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 29, 2023
@algorithms-keeper algorithms-keeper bot removed awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass labels Oct 29, 2023
@aqib-m31
Copy link
Contributor Author

All set! @cclauss

@cclauss cclauss enabled auto-merge (squash) October 29, 2023 16:41
cclauss
cclauss approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

josephus_recursive(996, 1) # RecursionError on my machine

josephus_iterative(996, 1) # Works just fine

@cclauss cclauss merged commit be60f42 into TheAlgorithms:master Oct 29, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@aqib-m31 @cclauss @sedatguzelsemme
Add Josephus Problem (TheAlgorithms#10928)
4894be0 
* Add Josephus Problem

* Add iterative implementation of Josephus Problem

* Add descriptive variable names

* Update maths/josephus_problem.py

* Update josephus_problem.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqib-m31 @cclauss