Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code to change contrast #1060

Merged
merged 6 commits into from
Jul 21, 2019
Merged

Code to change contrast #1060

merged 6 commits into from
Jul 21, 2019

Conversation

QuantumNovice
Copy link
Contributor

No description provided.

@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

If float works instead of int, then I am cool with that because it would deliver more fine-grained control but go with whatever works best for your algorithm.

@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

👍 Cool to see that mypy is working...
https://travis-ci.org/TheAlgorithms/Python/builds/561654753#L563

QuantumNovice
QuantumNovice commented Jul 21, 2019
View reviewed changes
Copy link
Contributor Author

@QuantumNovice QuantumNovice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@QuantumNovice
Copy link
Contributor Author

What would you suggest for writing doc-tests for image processing algorithms?

cclauss
cclauss approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great contribution. Thanks for your patience.

@cclauss cclauss merged commit 05e567c into TheAlgorithms:master Jul 21, 2019
@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

I see a lot of repos use https://pypi.org/project/selenium to compare images on webpages but I have not done it myself.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@QuantumNovice @stokhos
Code to change contrast (TheAlgorithms#1060)
85fb0aa 
* Add files via upload

* Update requirements.txt

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantumNovice @cclauss