Hacktoberfest: Added Octal Number to Hexadecimal Number Conversion Algorithm #10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-kush
changed the title
|
Hi, this is my first contribution for Hacktoberfest. Please add hacktoberfest label upon merging |
tianyizheng02
requested changes
Oct 15, 2023
fix: minor improvement to directly return hexadecimal value Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: improvement updates to octal to hexadecimal Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: Readablility improvements to octal to hexadecimal convertor Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: readability improvements in octal_to_hexadecimal.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
fix: readability improvements in octal_to_hexadecimal.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
…suggested changes
algorithms-keeper
bot
removed
the
tests are failing
tianyizheng02
requested changes
Oct 16, 2023
…_to_hexadecimal.py
|
@tianyizheng02 I have added the requested changes. Also, I aligned the tests accordingly, so that they do match with the expected output format "0x"+Hex_value |
tianyizheng02
approved these changes
Oct 17, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
|
Hi, @tianyizheng02 Can you please put hacktoberfest-accepted label on this pull request |
|
This repo already has the Hacktoberfest label, so there should be no need to label individual PRs. You should see this PR's status reflected on your Hacktoberfest profile shortly. |
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
…gorithm (TheAlgorithms#10533) * Added Octal to Hexadecimal Conversion program under 'conversions' directory * Update conversions/octal_to_hexadecimal.py fix: minor improvement to directly return hexadecimal value Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * Update conversions/octal_to_hexadecimal.py fix: improvement updates to octal to hexadecimal Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * Update conversions/octal_to_hexadecimal.py fix: Readablility improvements to octal to hexadecimal convertor Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * Update conversions/octal_to_hexadecimal.py fix: readability improvements in octal_to_hexadecimal.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * Update conversions/octal_to_hexadecimal.py fix: readability improvements in octal_to_hexadecimal.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> * fix: Fixed all the errors in octal_to_hexadecimal.py after commiting suggested changes * fix: modified the prefix of hex numbers to the '0x' standard in octal_to_hexadecimal.py --------- Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ectory
Describe your change:
Added Octal Number to Hexadecimal Number Conversion Algorithm under 'conversions' directory
Checklist: