Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_digital_image_processing -> test_local_binary_pattern replacing a large image with a smaller one #10161

Merged
merged 10 commits into from
Oct 9, 2023
Merged

test_digital_image_processing -> test_local_binary_pattern replacing a large image with a smaller one #10161

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eccea26
Replacing the generator with numpy vector operations from lu_decompos…
quant12345 Sep 29, 2023
4e34723
Revert "Replacing the generator with numpy vector operations from lu_…
quant12345 Sep 29, 2023
93dfe61
Replaced lena.jpg with lena_small.jpg to make tests faster.
quant12345 Oct 9, 2023
f50bcae
Update digital_image_processing/test_digital_image_processing.py
quant12345 Oct 9, 2023
b18c17b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 9, 2023
abaca17
Update test_digital_image_processing.py
quant12345 Oct 9, 2023
204b73c
Apply suggestions from code review
tianyizheng02 Oct 9, 2023
56b16ba
Update test_digital_image_processing.py
quant12345 Oct 9, 2023
ca1bd10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 9, 2023
b5d01de
Update test_digital_image_processing.py
quant12345 Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion digital_image_processing/test_digital_image_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def test_nearest_neighbour(


def test_local_binary_pattern():
file_path = "digital_image_processing/image_data/lena.jpg"
file_path = "digital_image_processing/image_data/lena_small.jpg"
Copy link
Member

@cclauss cclauss Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

Suggested change
file_path = "digital_image_processing/image_data/lena_small.jpg"
from os import getenv # Speed up our Continuous Integration tests
file_name = "lena_small.jpg" if getenv("CI") else "lena.jpg"
file_path = f"digital_image_processing/image_data/{file_name}.jpg"


# Reading the image and converting it to grayscale.
image = imread(file_path, 0)
Expand Down