Log_likelihood update #1008
Merged
Log_likelihood update #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple exploratory notebook that heavily expolits pandas and seaborn
Update with log_likelihood logistic_regression.py
cclauss
requested changes
Jul 12, 2019
| def log_likelihood(X, Y, weights): | ||
| scores = np.dot(features, weights) | ||
| ll = np.sum( target*scores - np.log(1 + np.exp(scores)) ) | ||
| return ll |
There was a problem hiding this comment.
Do not create the variable ll, it is not an intuitive name so just return the result. The function is self explanatory. Of course, a docstring, doctests, and type hints would not hurt.
There was a problem hiding this comment.
return np.sum(target * scores - np.log(1 + np.exp(scores)))
| @@ -55,6 +61,17 @@ def logistic_reg( | |||
| J = cost_function(h, y) | |||
|
|
|||
| iterations += 1 # update iterations | |||
|
|
|||
| for step in xrange(num_steps): | |||
There was a problem hiding this comment.
xrange() was removed in Python 3 so please use range() instead.
cclauss
reviewed
Jul 13, 2019
| scores = np.dot(X, weights) | ||
| predictions = sigmoid(scores) | ||
| if step % 10000 == 0: | ||
| print log_likelihood(X,Y,weights) # Print log-likelihood every so often |
There was a problem hiding this comment.
print() is a function in Python 3. --> print(log_likelihood(X, Y, weights))
cclauss
reviewed
Jul 13, 2019
| if step % 10000 == 0: | ||
| print log_likelihood(X,Y,weights) # Print log-likelihood every so often | ||
| return weights | ||
|
|
||
| if iterations == max_iterations: | ||
| print ('Maximum iterations exceeded!') | ||
| print ('Minimal cost function J=', J) |
There was a problem hiding this comment.
Style: No space between print and (.
|
Click the automated test below to see why it is failing... |
… wastage analysis from 1961-2013 (FAO).ipynb
ChillOrb
commented
Jul 13, 2019
cclauss
approved these changes
Jul 13, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add files via upload This is a simple exploratory notebook that heavily expolits pandas and seaborn * Update logistic_regression.py * Update logistic_regression.py * Rename Food wastage analysis from 1961-2013 (FAO).ipynb to other/Food wastage analysis from 1961-2013 (FAO).ipynb * Update logistic_regression.py * Update logistic_regression.py * Update logistic_regression.py * Update logistic_regression.py * Update logistic_regression.py * Update logistic_regression.py * Update logistic_regression.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.