Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abs_Min.py #1004

Merged
merged 5 commits into from
Jul 11, 2019
Merged

Update abs_Min.py #1004

merged 5 commits into from
Jul 11, 2019

Conversation

SandersLin
Copy link
Contributor

@SandersLin SandersLin commented Jul 11, 2019

from Maths.abs import absVal does not work.

@cclauss
Copy link
Member

cclauss commented Jul 11, 2019

Can you please rename the file to be all lowercase? That might cleanup the conflict below caused by #993 being merged.

@AnupKumarPanwar
Copy link
Member

@SandersLin Please resolve the conflicts

maths/abs_min.py Outdated
@@ -1,4 +1,4 @@
from Maths.abs import absVal
from abs import absVal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absVal doesn't exist in abs.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should resolve the conflicts. Thanks

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your pull request!🤩

@cclauss cclauss merged commit c2f2fa8 into TheAlgorithms:master Jul 11, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Update abs_Min.py

* Create __init__.py

* Rename abs_Min.py to abs_min.py

* Update abs_min.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants