-
-
Notifications
You must be signed in to change notification settings - Fork 46.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update abs_Min.py #1004
Update abs_Min.py #1004
Conversation
Can you please rename the file to be all lowercase? That might cleanup the conflict below caused by #993 being merged. |
@SandersLin Please resolve the conflicts |
maths/abs_min.py
Outdated
@@ -1,4 +1,4 @@ | |||
from Maths.abs import absVal | |||
from abs import absVal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absVal doesn't exist in abs.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should resolve the conflicts. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your pull request!🤩
* Update abs_Min.py * Create __init__.py * Rename abs_Min.py to abs_min.py * Update abs_min.py
from Maths.abs import absVal does not work.