Skip to content

Commit

Permalink
Pytest locally fails due to API_KEY env variable (#8738)
Browse files Browse the repository at this point in the history
* fix: Pytest locally fails due to API_KEY env variable (#8737)

* chore: Fix ruff errors
  • Loading branch information
CaedenPH authored Jun 3, 2023
1 parent 3a9e5fa commit 80d95fc
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions web_programming/currency_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,7 @@
import requests

URL_BASE = "https://www.amdoren.com/api/currency.php"
TESTING = os.getenv("CI", "")
API_KEY = os.getenv("AMDOREN_API_KEY", "")

if not API_KEY and not TESTING:
raise KeyError(
"API key must be provided in the 'AMDOREN_API_KEY' environment variable."
)

# Currency and their description
list_of_currencies = """
Expand Down Expand Up @@ -175,20 +169,31 @@


def convert_currency(
from_: str = "USD", to: str = "INR", amount: float = 1.0, api_key: str = API_KEY
from_: str = "USD", to: str = "INR", amount: float = 1.0, api_key: str = ""
) -> str:
"""https://www.amdoren.com/currency-api/"""
# Instead of manually generating parameters
params = locals()
# from is a reserved keyword
params["from"] = params.pop("from_")
res = requests.get(URL_BASE, params=params).json()
return str(res["amount"]) if res["error"] == 0 else res["error_message"]


if __name__ == "__main__":
TESTING = os.getenv("CI", "")
API_KEY = os.getenv("AMDOREN_API_KEY", "")

if not API_KEY and not TESTING:
raise KeyError(
"API key must be provided in the 'AMDOREN_API_KEY' environment variable."
)

print(
convert_currency(
input("Enter from currency: ").strip(),
input("Enter to currency: ").strip(),
float(input("Enter the amount: ").strip()),
API_KEY,
)
)

0 comments on commit 80d95fc

Please sign in to comment.