Added an explanation to SkylineProblem #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added and explanation to SkylineProblem.
yanglbme
reviewed
Oct 9, 2018
Others/Dijkstra.java
Outdated
| } | ||
|
|
||
| private void printPath() | ||
| { |
Member
There was a problem hiding this comment.
The opening brace { and method declarations should be on the same line. Most of the standard source code for the Java API is written in this style.
eg.
public Vertex(String name) {
this.name = name;
}
Member
There was a problem hiding this comment.
Also for the blocks inside a function.
if (this == this.previous) {
System.out.printf("%s", this.name);
}
Contributor
Author
There was a problem hiding this comment.
Updated brackets. New version here
Let me know if I missed any.
rmakynen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no explanation for the SkylineProblem algorithm, which caused the user to have to google. Now there user gets a quick overview of what the algorithm does.