Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java broken links #160

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Fix Java broken links #160

merged 3 commits into from
Sep 6, 2022

Conversation

alaanescobedo
Copy link
Contributor

HI! I open this PR in relation to this issue: #154

I know that there is already an open PR in #156, but it is more than 2 months old, so I had doubts about opening it.
I can find other broken links and fix them, but thought I'd leave this PR with just the Java links.

Panquesito7
Panquesito7 previously approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 requested a review from vbrazo March 23, 2022 17:57
@alaanescobedo
Copy link
Contributor Author

Oh sry! I put a broken link in en/Dynamic Programming/Longest Common Subsequence.md, I made the changes with a regex and I didn't notice it! in a moment I updated it

@github-actions
Copy link

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 23, 2022
@Panquesito7 Panquesito7 removed the stale label Apr 23, 2022
@Panquesito7
Copy link
Member

Sorry for the long delay. I'll check this out tomorrow. Thanks. 🙂

@AnujSsStw
Copy link

hey @Panquesito7 while checking this you should also consider checking other links too like this c++ one and there are some more that I think I saw.
Capture1

@github-actions
Copy link

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 31, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

@github-actions github-actions bot closed this Jun 8, 2022
@Panquesito7 Panquesito7 reopened this Sep 5, 2022
@Panquesito7 Panquesito7 removed the stale label Sep 5, 2022
Panquesito7
Panquesito7 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Maintainable

@Panquesito7 Panquesito7 merged commit 6023e94 into TheAlgorithms:master Sep 6, 2022
@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@vbrazo vbrazo Awaiting requested review from vbrazo vbrazo is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaanescobedo @Panquesito7 @AnujSsStw