Setup Jest #76
Merged
Setup Jest #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GP4cK
commented
Jun 16, 2021
Comment on lines
+38
to
+43
| overrides: [{ | ||
| files: ['*.spec.ts'], | ||
| env: { | ||
| jest: true, | ||
| }, | ||
| }], |
Contributor
Author
There was a problem hiding this comment.
This makes sure that when we are in a file that ends with .spec.ts, we can use the describe, test, expect etc. function without errors from the linter
GP4cK
commented
Jun 17, 2021
| "module": "ESNext", | ||
| /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */ | ||
| // "lib": [], /* Specify library files to be included in the compilation. */ | ||
| "allowJs": true, |
Contributor
Author
There was a problem hiding this comment.
Had to duplicate this file to set allowJS to true for the tests to run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TLDR:
as of now, we can't test files that importviewer.tsbut we can still test other files.Explanation:
I wanted to test the
Viewerconstructor and make sure that it creates a ThreeJs Scene. Unfortunately, it seems that the fact thatviewer.jsis importing a js file (three/examples/jsm/controls/OrbitControls.js) is causing issues with jest.The error I get is:
I tried a few things but I got stuck.
It ain't much but it's honest work.
EDIT: the tests are now working even with viewer.ts.