Standardize "extern" decls on AS_EXTERN #972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXTERN_C_BEGIN/EXTERN_C_END
aren't sufficient because outside of c++ they don't do anything. In C you cannot declare multiple functions extern in one shot. You must decorate each function anyway, so why bother with these?FOUNDATION_EXTERN
, UIKit usesUIKIT_EXTERN
on each function, and drops theBEGIN/END
.#define AS_EXTERN FOUNDATION_EXTERN
EXPORT
because that only matters when compiling for win32. Not aware of any intentions to port to windows 😂 😂 😂 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥The current definition of
FOUNDATION_EXTERN
is: