Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed removing node from supernode after layout transition #937

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

atitovdev
Copy link
Contributor

Fixed removing node from supernode after layout transition when automaticallyManagesSubnodes is disabled. In case if developer prefer to manage subnodes by himself then he wants to be sure that stack will not change automatically.

@CLAassistant
Copy link

CLAassistant commented May 23, 2018

CLA assistant check
All committers have signed the CLA.

@atitovdev atitovdev closed this May 23, 2018
@atitovdev atitovdev reopened this May 23, 2018
@ghost
Copy link

ghost commented May 23, 2018

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atitovdev Thanks for working on it!

Currently using the layout transition API is not officially supported without having automatic subside management enabled: http://texturegroup.org/docs/layout-transition-api.html

We’re not currently planning to break the behavior though if you are relying on it and therefore we would appreciate your input what is your use case for it so we can improve this in the future.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we don't officially support layout transition without ASM, but it doesn't hurt to make it less painful if you happen to rely on it.
I'm gonna merge this PR now, but feel free to share your use case when you have time, just so we can understand it better.

@nguyenhuy nguyenhuy merged commit 4669a24 into TextureGroup:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants