Update Podspec #866
Merged
Update Podspec #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2018 14:51
Adlai-Holler
commented
Apr 4, 2018
| @@ -14,8 +14,6 @@ Pod::Spec.new do |spec| | |||
| spec.ios.weak_frameworks = 'AssetsLibrary' | |||
| spec.weak_frameworks = 'Photos','MapKit' | |||
|
|
|||
| spec.requires_arc = true | |||
|
|
|||
There was a problem hiding this comment.
This has been the default since 2014.
Adlai-Holler
commented
Apr 4, 2018
| @@ -41,7 +39,6 @@ Pod::Spec.new do |spec| | |||
| # See https://github.com/facebook/AsyncDisplayKit/issues/1153 | |||
| 'Source/TextKit/*.h', | |||
| ] | |||
| core.xcconfig = { 'GCC_PRECOMPILE_PREFIX_HEADER' => 'YES' } | |||
There was a problem hiding this comment.
We no longer use a prefix header.
Adlai-Holler
commented
Apr 4, 2018
| 'CLANG_CXX_LANGUAGE_STANDARD' => 'c++11', | ||
| 'CLANG_CXX_LIBRARY' => 'libc++' | ||
| } | ||
|
|
There was a problem hiding this comment.
(See PR description). These options have been here since the initial OSS release and aren't adding value anymore. The default clang C++ options under Xcode 9 (and probably Xcode 8) are sufficient.
maicki
approved these changes
Apr 4, 2018
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Update the podspec * Put that back * Put back the C++ standard library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.
The motivating factor for this diff is that the explicit specification of C++ options forced Pinterest's build system (based on Bazel) to build all Texture files using a C++ compiler. The recent file
ASRecursiveUnfairLock.mcannot be built with a C++ compiler and so that broke the build. Other clients are also using this "all-C++" workaround as well.The default C++ options (currently GNU++14) will probably be fine indefinitely. We can always reintroduce these flags if we decide to lean on, say, c++17 options but for now let's toss them overboard.