[ASCellNode] focusStyle mapping #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maicki
requested changes
Dec 29, 2017
There was a problem hiding this comment.
Hey @alexhillc thanks for working on this PR. focusStyle is available starting with iOS 9, but Texture is still supporting iOS 8. Can you please guard against this. Thanks!
|
Hey @maicki thanks for reviewing. I've been building against the tvOS SDK, so I must have missed it. Fixed in the latest commit! |
maicki
previously requested changes
Dec 29, 2017
Source/ASTableView.mm
Outdated
| self.selectedBackgroundView = node.selectedBackgroundView; | ||
| self.separatorInset = node.separatorInset; | ||
| self.selectionStyle = node.selectionStyle; | ||
| self.accessoryType = node.accessoryType; | ||
|
|
||
| if (AS_AVAILABLE_IOS(9.0)) { |
There was a problem hiding this comment.
To be consistent can you please change that to 9
|
@alexhillc We've dropped iOS 8 support (#743). Could you please update this diff one more time? Thank you! |
alexhillc
force-pushed
the
cell-focus-style
branch
from
a4da0e9
to
13fdf5d
Compare
|
@nguyenhuy, done! |
nguyenhuy
approved these changes
Jan 16, 2018
alexhillc
force-pushed
the
cell-focus-style
branch
from
2f45fea
to
65ee53e
Compare
|
Awesome thanks all. Let's get that PR in than. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* [ASCellNode] Adds mapping for UITableViewCell focusStyle * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting
focusStyleon anASCellNode.